BF: correct handling of output paths in dipy_quickbundles. #915
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to get a test of this, so that it doesn't creep back in? |
|
Yes, incoming. |
|
🍠 |
|
Just to add, as I posted in an edit to the PR description: I also checked that the other scripts do not have a similar behavior. They don't. |
| # Need to specify an output directory with a "../" style path | ||
| # to trigger old bug. | ||
| cmd = ["dipy_quickbundles", tracks_file, '--pkl_file', 'mypickle.pkl', | ||
| '--out_file', '../output/tracks300.trk'] |
There was a problem hiding this comment.
I am not sure that this will work well when testing on a Windows platform (because the path separator is hard coded here). I am running a test of that over here: https://ci.appveyor.com/project/arokem/dipy/build/1.0.649, but it might take a couple of hours to finish running.
|
Ok I pushed a new version with better handling for the path separators. |
|
Great. Thanks! |
arokem
added a commit
that referenced
this pull request
Feb 15, 2016
BF: correct handling of output paths in dipy_quickbundles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now using a splitext call to correctly get the full path of the output file.
Previously, setting the output_file as something in another directory (by using a path like "../other_dir/output.trk") would still output all files in the current directory, with a broken name.
EDIT: I also checked that the other scripts do not have a similar behavior. They don't.