Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile Images don't load on wallet #53

Closed
tobias-g1 opened this issue Jan 25, 2019 · 2 comments
Closed

Profile Images don't load on wallet #53

tobias-g1 opened this issue Jan 25, 2019 · 2 comments
Assignees
Labels
bug Something isn't working priority Needs to be done ASAP taken Already taken by a contibutor

Comments

@tobias-g1
Copy link

Describe the bug
When viewing a users profile on the profile page, the profile image doesn't display correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to your wallet.
  2. Note that the profile image doesn't load.

I suspect this isn't happening to every user, this may not be able to replicate.

Expected behaviour
A user's profile image should always be displayed correctly.

Screenshots
The following screenshot provides additional clarity surrounding the issue:

image

Browser: Google Chrome (Version 71.0.3578.98 (Official Build) (64-bit))
Device: MacBook Pro (Retina, 15-inch, Late 2013)
Operating system: MacOS Mojave Version 10.14.1 (18B75)

A simple a more flexible solution would replace:

this.profile_url = this.profile && this.profile.profile ? this.profile.profile.profile_image : '';

so that the profile image is no longer pulled from the json_metadata, this prevents a number of issues that can pop up surrounding profile images not being loaded correctly. If you instead use:

https://steemitimages.com/u/${username}/avatar

This would also handle broken images with a fallback.

@tobias-g1 tobias-g1 changed the title Profile Images doesn't load on wallet Profile Images don't load on wallet Jan 25, 2019
@nirvanaitsolutions nirvanaitsolutions added the bug Something isn't working label Jan 26, 2019
@nirvanaitsolutions
Copy link
Owner

@bunyy I'll fix this.

@nirvanaitsolutions
Copy link
Owner

@bunyy canyou fix it asap?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority Needs to be done ASAP taken Already taken by a contibutor
Projects
None yet
Development

No branches or pull requests

5 participants