Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some accessibility issues #5

Closed
wants to merge 4 commits into from
Closed

Fixed some accessibility issues #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e2cdc3e
Fixed some accessibility issues
Vikram-Hegde Jul 11, 2020
4b5be2c
Update index.css
Vikram-Hegde Jul 19, 2020
a8c4e05
Update index.html
Vikram-Hegde Jul 19, 2020
38c3fb1
Merge branch 'master' into master
Vikram-Hegde Oct 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
/* --------------------------------------- */

@font-face {
font-family: 'Hk Grotesk';
font-family: "Hk Grotesk";
font-style: normal;
font-weight: 400;
src: url('./fonts/HKGrotesk-Regular.woff') format('woff');
src: url("./fonts/HKGrotesk-Regular.woff") format("woff");
}

@font-face {
font-family: 'Jost';
font-family: "Jost";
font-style: normal;
font-weight: 400;
src: url('./fonts/Jost-Regular.ttf') format('woff');
src: url("./fonts/Jost-Regular.ttf") format("woff");
}

* {
Expand All @@ -29,7 +29,7 @@
--font-size-medium-1: 3.6rem;
--font-size-large: 5.5rem;
--font-size-huge: 7.5rem;
--font-stack: 'Hk Grotesk', sans-serif;
--font-stack: "Hk Grotesk", sans-serif;

--line-height-normal: 1.7;
--line-height-small: 1.2;
Expand All @@ -39,7 +39,6 @@
--white: #f0e9f2;
--white-1: #e5e5e6da;


--container-max-width: 1180px;
--container-normal-width: 800px;
--container-medium-width: 700px;
Expand Down Expand Up @@ -122,7 +121,7 @@ img {
h1,
h2,
h3 {
font-family: 'Jost', sans-serif;
font-family: "Jost", sans-serif;
font-weight: 400;
line-height: var(--line-height-small);
color: var(--white);
Expand All @@ -146,7 +145,7 @@ h2 {
}

h2::after {
content: '';
content: "";
display: block;
height: 2px;
width: 10rem;
Expand Down Expand Up @@ -190,8 +189,8 @@ p {
a {
color: var(--white);
font-weight: 400;
font-family: 'Jost', sans-serif;
transition: all .2s;
font-family: "Jost", sans-serif;
transition: all 0.2s;
outline: 2px solid transparent;
}

Expand All @@ -218,17 +217,17 @@ body:not(.user-is-tabbing) a:focus {
display: inline-block;
padding: 1rem 4.2rem;
text-decoration: none;
color: inherit;
border: 1px solid var(--pink);
color: #000;
font-weight: 400;
box-sizing: border-box;
}

.btn:focus {
outline: none;
}

.btn::after {
content: '';
content: "";
display: block;
position: absolute;
top: 0;
Expand Down Expand Up @@ -258,19 +257,21 @@ body:not(.user-is-tabbing) a:focus {
.btn--pink:hover,
.btn--pink:focus {
background: transparent;
border: 1px solid white;
color: white;
}

.link__text {
position: relative;
display: inline-block;
padding: .6rem;
padding: 0.6rem;
color: inherit;
text-decoration: none;
border-bottom: 1px solid var(--pink);
}

.link__text::after {
content: '';
content: "";
display: block;
position: absolute;
top: 0;
Expand Down Expand Up @@ -312,7 +313,7 @@ body:not(.user-is-tabbing) a:focus {
border-radius: 50%;
z-index: 10;
visibility: hidden;
transition: all .4s;
transition: all 0.4s;
}

.back-to-top__image {
Expand Down Expand Up @@ -374,11 +375,11 @@ body:not(.user-is-tabbing) a:focus {
padding: 1rem 0;
text-decoration: none;
color: inherit;
transition: all .2s;
transition: all 0.2s;
}

.nav__link::after {
content: '';
content: "";
position: absolute;
bottom: 0;
left: 0;
Expand All @@ -404,8 +405,8 @@ body:not(.user-is-tabbing) a:focus {
/* --------------------------------------- */

.header {
background: linear-gradient(rgba(0,0,0, .1), rgba(0,0,0, .4)),
url('./images/header.jpg');
background: linear-gradient(rgba(0, 0, 0, 0.1), rgba(0, 0, 0, 0.4)),
url("./images/header.jpg");
height: 100vh;
background-size: cover;
background-position: center;
Expand All @@ -422,7 +423,7 @@ body:not(.user-is-tabbing) a:focus {
.header__text p {
margin: 1.5rem 0 3.5rem;
max-width: var(--container-medium-width);
font-family: 'Jost', sans-serif;
font-family: "Jost", sans-serif;
font-size: var(--font-size-medium);
}

Expand All @@ -432,7 +433,7 @@ body:not(.user-is-tabbing) a:focus {
}

.header__text p {
transform: scale(.8);
transform: scale(0.8);
}
}

Expand Down Expand Up @@ -481,7 +482,7 @@ body:not(.user-is-tabbing) a:focus {
display: block;
height: 3rem;
margin-left: var(--gutter-normal);
transition: all .3s;
transition: all 0.3s;
}

.work__code:hover {
Expand Down Expand Up @@ -512,7 +513,7 @@ body:not(.user-is-tabbing) a:focus {
.client__logos {
display: flex;
justify-content: space-between;
filter: invert(100%) grayscale(100%) opacity(.8);
filter: invert(100%) grayscale(100%) opacity(0.8);
}

.client__logo {
Expand Down
12 changes: 6 additions & 6 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,12 +94,12 @@ <h3>Portfolio Template</h3>
Visit Site <span>&rarr;</span>
</a>
<a href="https://github.com/nisarhassan12/portfolio" title="View Source Code" target="_blank">
<img src="./images/github.svg" class="work__code" alt="GitHub">
<img src="./images/github.svg" class="work__code" alt="Github link to source code">
</a>
</div>
</div>
<div class="work__image-box">
<img src="./images/project-1.png" class="work__image" alt="Project 1" />
<img src="./images/project-1.png" class="work__image" alt="Portfolio Template" />
</div>
</div>

Expand All @@ -122,12 +122,12 @@ <h3>Calculator</h3>
Visit Site <span>&rarr;</span>
</a>
<a href="#">
<img src="./images/github.svg" class="work__code" title="View Source Code" alt="GitHub">
<img src="./images/github.svg" class="work__code" title="View Source Code" alt="Github link to the Source Code">
</a>
</div>
</div>
<div class="work__image-box">
<img src="./images/project-2.png" class="work__image" alt="Project 1" />
<img src="./images/project-2.png" class="work__image" alt="Image showcasing Calculator Project" />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see https://github.com/nisarhassan12/portfolio-template/pull/5/files?diff=unified&w=1#r456755433

</div>
</div>

Expand All @@ -150,12 +150,12 @@ <h3>Notificator</h3>
Visit Site <span>&rarr;</span>
</a>
<a href="#">
<img src="./images/github.svg" class="work__code" title="View Source Code" alt="GitHub">
<img src="./images/github.svg" class="work__code" title="View Source Code" alt="Github link to source code">
</a>
</div>
</div>
<div class="work__image-box">
<img src="./images/project-3.png" class="work__image" alt="Project 3" />
<img src="./images/project-3.png" class="work__image" alt="Image showcasing notificator project" />
</div>
</div>
</div>
Expand Down