Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default modules not showing for strangers #36

Closed
mschlesinger19 opened this issue Apr 24, 2020 · 5 comments
Closed

default modules not showing for strangers #36

mschlesinger19 opened this issue Apr 24, 2020 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@mschlesinger19
Copy link

I have found that when the module recognizes a stranger, those modules just labeled "default" are not shown. Classes "default everyone" are shown for strangers but "default" are not shown. Is anyone else seeing this issue? Maybe my configuration is incorrect.

@nischi nischi self-assigned this Apr 29, 2020
@nischi nischi added the bug Something isn't working label Apr 29, 2020
@nischi
Copy link
Owner

nischi commented Apr 29, 2020

Should be like you said. I need to test that on my system and fix it.

@nischi nischi added this to the 1.0.7 milestone May 5, 2020
@robertybob
Copy link

@nischi have you had the opportunity to work on this? :)

@nischi
Copy link
Owner

nischi commented Aug 13, 2020

I'm sorry, not yet.

@majurgens
Copy link
Contributor

majurgens commented Aug 16, 2020

I have a similar problem but with "everyone".
I've have found that there are other classes that work in specific ways.

  • "nobody" works that same as "default". It seems that any other made up class name works like "default". This may help mschlesinger19
  • "unknown" works when someone who is unknown to the facial recognition logs in - this seems to be an extra undocumented class. This is useful functionality. It also allows me to work around "everyone" not working correctly, by doing the extra configuration of using all the known profiles and "unknown" instead of "everyone"

For me,

  • when there is no one in front of the camera: VISIBLE="default", "default everyone", "everyone default", "nobody" INVISIBLE="unknown"
  • when I login as "me": VISIBLE="me", "default everyone", "everyone default" INVISIBLE="unknown", "everyone" (ERROR), "default"
  • when someone else who is known logs in: VISIBLE="default everyone", "everyone default" are visible INVISIBLE="unknown", "everyone" (ERROR), "default"
  • when someone who is unknown logs in: VISIBLE="default everyone", "everyone default", "unknown" INVISIBLE="unknown", "everyone" (ERROR), "default"

@majurgens
Copy link
Contributor

I've looked at the code and there is actually nowhere in the code that will show the "everyone" class when a user logs in and hide it when they log out. This is why it does not work.

There is code in there that would

  • not hide "everyone" if it was already showing when someone logs in. This seems to assume that before login "everyone" would already be showing, which is not how "everyone" is supposed to work
  • not show "everyone" when someone logs and there are no more logged in users. Again, the same logic that seems to assume you want to show "everyone" when someone logs out.

The code looks good for "default" so I'm not sure what the problem is as reported by mschlesinger19

I have fix up the code in my local version. I'm not sure how I would go about putting it back in github .....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants