Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Highlighting Issue #5

Closed
gantonious opened this issue Nov 13, 2018 · 7 comments
Closed

Syntax Highlighting Issue #5

gantonious opened this issue Nov 13, 2018 · 7 comments

Comments

@gantonious
Copy link

gantonious commented Nov 13, 2018

I haven't had enough time to look into the exact issue but I noticed earlier today that Kotlin syntax highlighting isn't working as expected. See the following sample file in linguist: https://github.com/github/linguist/blob/master/samples/Kotlin/Foo.kt

It looks like linguist just had a release earlier today and I think that's when it broke. See github-linguist/linguist#4324.

@gantonious
Copy link
Author

gantonious commented Nov 14, 2018

Just a quick follow up from yesterday. I quickly spun up a VSCode language extension using the same syntax currently being used by linguist and it seems to be working fine in VSCode (note I just tested the plist file not the YAML):

image

@nishtahir
Copy link
Owner

nishtahir commented Nov 14, 2018

Thanks for reporting this. I started looking into this yesterday and it seems that the bug has something to do with

which was to allow for generics in types.

It looks like VSCode and GitHub treat these very differently. After removing it and testing it with lightshow. It seems to work correctly.

I've pushed a fix for it in 69733ef

@Zhuinden
Copy link

Zhuinden commented Nov 17, 2018

Is this fix out and available? I'm asking because PRs that I'm reviewing still show up with pretty much all the code ending up in a blue-ish (purple) tint.

@gantonious
Copy link
Author

It should be out when github/lingust does another release. See: github-linguist/linguist#4329

@lildude
Copy link

lildude commented Nov 22, 2018

GitHub should now be rendering Kotlin files correctly again.

@nishtahir
Copy link
Owner

Thanks, @lildude!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants