Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine code #2

Open
niszet opened this issue Jul 29, 2020 · 1 comment
Open

Refine code #2

niszet opened this issue Jul 29, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@niszet
Copy link
Owner

niszet commented Jul 29, 2020

exported functions have 3 types of input:

  • docx file path
  • xml object
  • data.frame

These are easy to get confused. functions must have prefix and any other mark in those names.

@niszet niszet added the enhancement New feature or request label Jul 29, 2020
@niszet niszet self-assigned this Jul 29, 2020
@niszet
Copy link
Owner Author

niszet commented Aug 10, 2020

Added "file" to the docx related argument. i.e. read_styles, write_styles.
In this package, the name xml should not be used. Use node instead. Or, docx_styles, styles_node, style_nodes and so on.

For data.frame, use df as a name of argument.

Suffix or prefix of function names are under consideration...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant