Add/initial commit #1

dz0ny · 2016-10-31T10:23:33Z

A bit of work left, before this can be used

dz0ny · 2016-10-31T10:23:59Z

docker-compose.yml

+  ports:
+    - 80:80
+  volumes:
+   - ./src:/var/www/html/wp-content/plugins/spiderblocker:ro


dz0ny · 2016-10-31T10:27:58Z

src/index.php

+    die();
+}
+
+// How do you debug your AJAX calls, how do you sleep at night?


wp-debug-toolbar :)

dz0ny · 2016-10-31T10:29:20Z

src/index.php

+
+    function __construct()
+    {
+        if (is_admin()) {


Also limit to user current_user_can('delete_themes') for example

Using current_user_can resulted in a strange error on my test setup. I'm still looking into this.
PHP message: PHP Fatal error: Call to undefined function wp_get_current_user() in /srv/www/cinn/wp-includes/capabilities.php on line 448

Initialize plugin at init hook? plugins_loaded is probably too soon

dz0ny · 2016-10-31T10:30:13Z

src/index.php

+        $this->themes_root = FooterLinks::joinPaths(ABSPATH, 'wp-content', 'themes');
+    }
+
+    function generateRewriteRules($wp_rewrite)


Needs to be setup with hook

dz0ny · 2016-10-31T10:31:51Z

src/index.php

+                $paths[] = $arg;
+            }
+        }
+        return preg_replace('#/+#', '/', join('/', $paths));


DIRECTORY_SEPARATOR instead of /

dz0ny · 2016-10-31T10:35:32Z

src/index.php

+        } catch (Exception $e) {
+            // Something went wrong, clean up
+            try {
+                foreach (glob("{$this->child_dir}/*") as $f) {


directory iterator please

dz0ny · 2016-10-31T10:37:41Z

src/index.php

+        <hr/>
+        <div ng-app="footerLinksApp">
+            <div ng-controller="MajikCtrl">
+                <h2>Input CSS class</h2>


I was wondering if we could add this into the theme preview and use their apis? New wp 4.7 also supports custom css for all themes directly from theme selector, can we use that?

dz0ny · 2016-10-31T10:38:14Z

src/index.php

+
+// Inside WordPress
+if (defined('ABSPATH')) {
+    $NiteowebFooterLinks_ins = new FooterLinks;


Add namescape :) This is mostly because of this https://wordpress.org/plugins/search.php?type=term&q=Footer+Links (1000+ plugins that mig use that function name)

dz0ny · 2016-10-31T10:39:45Z

tests/TestFooterLinks.php

+            )
+        );
+
+        \WP_Mock::wpFunction('wp_next_scheduled', array(


dz0ny · 2016-10-31T10:40:05Z

tests/TestFooterLinks.php

+        $plugin = new FooterLinks;
+        $plugin->adminMenu();
+
+    }


Missing other tests

dz0ny · 2016-11-10T18:27:54Z

src/index.php

-            add_action('admin_menu', array(&$this, 'adminMenu'));
-            add_action('wp_ajax_NFL-patch_theme', array(&$this, 'patchTheme'));
+        }
+        if (current_user_can('edit_themes')) {


edit_theme_options , edit_themes is FS rule which is not allowed in EBN.

dz0ny · 2016-11-10T18:30:02Z

src/index.php

-    }
+        if (array_key_exists($theme_stylesheet, $this->themes)) {
+            $opts['hide-class'] = $this->themes[$theme_stylesheet];
+            update_option('ebn_options', $opts);


ebn should not be mentioned anywhere in plugin...

dz0ny · 2016-11-10T18:30:30Z

src/index.php

+        $wp_customize->add_section(
+            'ebn_settings_section',
+            array(
+                'title'         => 'EBN Settings',


"footprint"

dz0ny · 2016-11-10T18:30:34Z

src/index.php

-                &$this,
-                'viewHandler'
+        $wp_customize->add_section(
+            'ebn_settings_section',


"footprint"

dz0ny · 2016-11-10T18:30:53Z

src/index.php

-        <?php }
-    }
+        $wp_customize->add_setting(
+            'ebn_options[hide-enabled]',


"footprint"

dz0ny · 2016-11-10T18:31:03Z

src/index.php

-        delete_option('nfl_activation');
-    }
+        $wp_customize->add_setting(
+            'ebn_options[hide-class]',


"footprint"

dz0ny · 2016-11-10T18:31:29Z

src/index.php

+            $wp_customize->add_control(
+                'ebn_hide_class_control',
+                array(
+                    'label'         => 'CSS class to hide',


The label should only read 'CSS Rule' ? :)

dz0ny · 2016-11-10T18:31:47Z

src/index.php

+                'ebn_hide_class_control',
+                array(
+                    'label'         => 'CSS class to hide',
+                    'description'   => 'Some meaningful description of what needs to be here.',


CSS Rule that will hade copyright info

dz0ny · 2016-11-10T18:32:58Z

src/index.php

+            add_option('nfl_activation', 'EXTERMINATE');
+            ?>
+            <div class="notice notice-success">
+                <p>Hide Footer Links plugin has been enabled.</p>


@dmurko Probably some link to help docs?

@dz0ny I would add help docs to the WordPress.org site when it's online.

dz0ny

Still needs some work, and tests are missing

dz0ny · 2016-11-14T09:16:54Z

src/index.php

+    // Array of themes and class name to hide. Maybe extend this to hold an
+    // array of classes or an override function for more complex solutions.
+    private $themes = array(
+        'twentysixteen' => 'site-info',


Little too broad?

Created plugin.

46a5bd4

dz0ny commented Oct 31, 2016

View reviewed changes