Skip to content
This repository has been archived by the owner on Jun 8, 2021. It is now read-only.

Possible bug with maxDistance #6

Closed
WazWaz opened this issue Oct 8, 2015 · 1 comment
Closed

Possible bug with maxDistance #6

WazWaz opened this issue Oct 8, 2015 · 1 comment

Comments

@WazWaz
Copy link

WazWaz commented Oct 8, 2015 

   bounds.Expand(new Vector3(maxDistance, maxDistance, maxDistance));

Shouldn't these be maxDistance*2, since Expand increases the size, but only 1/2 in each of 6 directions?

I noticed this while implementing a GetNearby(Vector3 point) version, not actually seeing a bug from it.
@Nition
Copy link
Owner

Nition commented Oct 8, 2015

Just checked the code. I think you're absolutely right. I'll check out your other bug report soon as well.

Nition added a commit that referenced this issue Oct 8, 2015
@Nition
Fixing issue #6, GetNearby using maxDistance instead of maxDistance * 2.
3630dc1
@Nition Nition closed this as completed Oct 8, 2015
@Nition Nition mentioned this issue Oct 8, 2015
Closed
kevinpthorne pushed a commit to kevinpthorne/UnityOctree that referenced this issue Apr 8, 2020
@mtschoen-unity
Merge pull request Nition#6 from Unity-Technologies/struct-octreeobject
8615812 
Use a struct and RemoveAt for OctreeObject
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WazWaz @Nition