-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] ModuleTrainer class #7
Comments
Sounds like a great idea! ;) |
check out what I just put in |
Amazing! This is definitely what I had in mind! I saw that you added support for multiple forwards inputs*. That's something I was really looking for! The History callback class seems to be looking for non existing attributes in the model. Maybe the History constructor should accept a ModuleTrainer as init parameter? (Although this sounds like a circular dependency...). I've removed it from the callbacks from now in ModuleTrainer self._callbacks = [self.history]
#-->
self._callbacks = []
Thanks again for the excellent work! |
should be fixed can you check? |
closed bc ModuleTrainer was added |
Can confirm ModuleTrainer works! |
Could potentially add a
ModuleTrainer
orModelTrainer
class that works similarly toSuperModule
but can take in one or more normalnn.Module
classes.. This would allow for support of pre-trained networks and more flexible training structures, while also allowing seamless integration with all other pytorch code@recastrodiaz
The text was updated successfully, but these errors were encountered: