Skip to content
This repository has been archived by the owner on Aug 7, 2022. It is now read-only.

clicking and dragging toolbars/sidebars duplicates last icon in a different way #36

Closed
luzpaz opened this issue May 19, 2016 · 3 comments

Comments

@luzpaz
Copy link
Contributor

luzpaz commented May 19, 2016

This is slightly different than #31 so I opened a new ticket:
To reproduce:

  1. Click and hold on the left toolbar in an empty space (not on a icon)
  2. While the mouse button is still depressed move the mouse upwards towards the icon above it
    Result:
    On the left toolbar: the above icon will be a duplicate of the icon that you're moving
    On the right toolbar: you'll see the same phenomena as the left toolbar + the first icon at the top of the toolbar disappears.
    See gif

duplicate-icon-case-2

@luzpaz
Copy link
Contributor Author

luzpaz commented May 19, 2016

Refinement: the left toolbar example is just showing us the bug when there are only 2 icons in the toolbar. If there are more that 2 you see the effect that happens in the right toolbar.

@nitramr
Copy link
Owner

nitramr commented May 19, 2016

Should be fixed in 9fe9da3. I've added a flag which starts dragging only if mouse was pressed over a tab.

@luzpaz
Copy link
Contributor Author

luzpaz commented May 19, 2016

Confirmed fix on 9fe9da3
Nice job @nitramr 👍

@luzpaz luzpaz closed this as completed May 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants