Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make options optional in api routes #165

Merged
merged 13 commits into from
Mar 3, 2023

Conversation

HomelessDinosaur
Copy link
Member

No description provided.

@HomelessDinosaur
Copy link
Member Author

The api.test.ts file had one change which changed the ordering of the parameters, the rest of the changes are just prettier.

@HomelessDinosaur HomelessDinosaur changed the title Feat/route middleware fix: make options optional in api routes Feb 17, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 85.81% // Head: 85.96% // Increases project coverage by +0.15% 🎉

Coverage data is based on head (02e6ce4) compared to base (13a77b3).
Patch coverage: 91.89% of modified lines in pull request are covered.

❗ Current head 02e6ce4 differs from pull request most recent head 3f0eea4. Consider uploading reports for the commit 3f0eea4 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #165      +/-   ##
===========================================
+ Coverage    85.81%   85.96%   +0.15%     
===========================================
  Files           82       82              
  Lines         1445     1468      +23     
  Branches       143      162      +19     
===========================================
+ Hits          1240     1262      +22     
- Misses         203      204       +1     
  Partials         2        2              
Impacted Files Coverage Δ
src/faas/v0/context.ts 76.22% <50.00%> (ø)
src/resources/api.ts 86.66% <93.05%> (+1.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tjholm added a commit to nitrictech/docs that referenced this pull request Mar 2, 2023
@tjholm tjholm merged commit 060acb9 into nitrictech:develop Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants