Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework bucket notification DX #181

Conversation

HomelessDinosaur
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -3.55 ⚠️

Comparison is base (0664462) 85.90% compared to head (18fc36e) 82.35%.

❗ Current head 18fc36e differs from pull request most recent head ff9c003. Consider uploading reports for the commit ff9c003 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    85.90%   82.35%   -3.55%     
===========================================
  Files           83       84       +1     
  Lines         1518     1666     +148     
  Branches       207      233      +26     
===========================================
+ Hits          1304     1372      +68     
- Misses         214      286      +72     
- Partials         0        8       +8     
Impacted Files Coverage Δ
src/faas/v0/handler.ts 100.00% <ø> (ø)
src/faas/v0/context.ts 54.77% <18.42%> (-21.57%) ⬇️
src/faas/v0/start.ts 32.23% <27.58%> (-1.37%) ⬇️
src/resources/api.ts 84.03% <86.11%> (+0.70%) ⬆️
src/resources/bucket.ts 84.00% <95.23%> (+9.64%) ⬆️
src/api/events/v0/events.ts 98.30% <100.00%> (+0.02%) ⬆️
src/api/queues/v0/queues.ts 96.29% <100.00%> (-0.05%) ⬇️
src/api/storage/v0/storage.ts 97.00% <100.00%> (+0.12%) ⬆️
src/resources/queue.ts 78.94% <100.00%> (ø)
src/resources/schedule.ts 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@davemooreuws davemooreuws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of things

package.json Outdated Show resolved Hide resolved
src/api/storage/v0/storage.ts Show resolved Hide resolved
src/resources/bucket.ts Outdated Show resolved Hide resolved
@davemooreuws davemooreuws merged commit dc7859c into nitrictech:develop May 15, 2023
1 check passed
@HomelessDinosaur HomelessDinosaur deleted the feat/file-notification-context branch May 15, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants