Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish src #206

Closed
1 of 3 tasks
TrejGun opened this issue Nov 5, 2020 · 6 comments
Closed
1 of 3 tasks

Do not publish src #206

TrejGun opened this issue Nov 5, 2020 · 6 comments

Comments

@TrejGun
Copy link

TrejGun commented Nov 5, 2020

Checklist

Description

I just realized that you are publishing src folder together with dist folder, probably for types
Guys there is one huge downsite for this
My TS config is more strict than yours and for latest version i have error

../../node_modules/mui-rte/src/MUIRichTextEditor.tsx(114,6): error TS6196: 'TCustomRenderers' is declared but never used.

and therefore can't compile my project. Can you please build with tsc? this will give you code and types to publish as npm

in case you want to create umd/cjs you can still use rollup but there is no need to include this build in npm you can destribute it separatly using unpkg

@niuware
Copy link
Owner

niuware commented Nov 5, 2020

This is fixed on version 1.26.1.

@niuware niuware closed this as completed Nov 5, 2020
@TrejGun
Copy link
Author

TrejGun commented Nov 5, 2020

thanks

@vilanz
Copy link

vilanz commented Mar 15, 2021

@niuware src is still being published in version 1.26.2.

@vilanz vilanz mentioned this issue Mar 15, 2021
3 tasks
@TrejGun
Copy link
Author

TrejGun commented Mar 15, 2021

@vilanz you can use my fork
https://github.com/paktolus/mui-rte

@niuware
Copy link
Owner

niuware commented Mar 16, 2021

@niuware src is still being published in version 1.26.2.

Gonna work on this as soon as I can 👍

@niuware
Copy link
Owner

niuware commented Mar 21, 2021

The source files are removed from version 1.28.0.

@niuware niuware closed this as completed Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants