Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans to migrate from jss to emotion? #284

Open
3 tasks done
hoangbn opened this issue Nov 17, 2021 · 9 comments
Open
3 tasks done

Plans to migrate from jss to emotion? #284

hoangbn opened this issue Nov 17, 2021 · 9 comments

Comments

@hoangbn
Copy link

hoangbn commented Nov 17, 2021

Checklist

Description

Is this package going to migrate from jss to emotion (i.e remove @mui/styles) eventually? I recently migrated to mui5 and tried to remove @mui/styles (with tss-react), but mui-rte still needs it, so I'm still stuck with JSS in my bundles.

@Nefcanto
Copy link

I have the same issue here. Based on the Docs, @mui/styles is deprecated and it's not compatible with React 18 (soon to come) and React.StrictMode which we DO use.

Thus I can't also use this library. I hope they migrate.

1 similar comment
@Nefcanto
Copy link

I have the same issue here. Based on the Docs, @mui/styles is deprecated and it's not compatible with React 18 (soon to come) and React.StrictMode which we DO use.

Thus I can't also use this library. I hope they migrate.

@niuware
Copy link
Owner

niuware commented Dec 21, 2021

Will look into that, but can't promise any release date for that. Anyone who can create a PR for this would be very welcome.

@AntonOfTheWoods
Copy link

If anyone is interested, I have created a migration that seems to work. I definitely haven't tested everything and in it's current form it changes everything because I am pretty picky about spaces and semi-colons.

https://github.com/transcrobes/mui-rte/tree/no-mui-styles

I also install direct from github and I couldn't work out how to do that without including a dist folder, which is just plain nasty (but is there any other way with npm?).

I could try and rework it but I don't have the bandwidth to take anything over and cleaning it up so it makes the minimum number of changes will actually take quite a bit of effort. If there is a lot of interest and a promise of quick reviews I will do it, otherwise I'm ok with my hack.

@nadersal
Copy link

I was able to update to MUI v5 using React v17, tss-react v 4.17. Make sure when replacing the makeStyles-calls from old mui/styles with makeStyles-calls form tss-react, delete the inner calls of createStyle.

@alaindeurveilher
Copy link

Hello, is there more visibility regarding the release of the compatibility with the latest version of React please ? Thank you.

@AntonOfTheWoods
Copy link

@AlainD- , there hasn't been any commit activity on this repo in around 2 years, and from the looks of it, the maintainer hasn't been active on any public repos in almost a year. I would consider this project "on hiatus" at best. I ended up just copying all the code into my project and putting a commit ref in the containing directory...

@alaindeurveilher
Copy link

Thank you @AntonOfTheWoods for replying. I think I will end up doing the same as a short term solution, as I don’t see a lot of ready solutions out there at the moment. Or I will try to implement my own solution then. Thank you again for having shared your solution.

@gudlyf
Copy link

gudlyf commented Feb 27, 2023

@AntonOfTheWoods @AlainD- I've since moved on to Lexical for my RTE needs. Heavily supported (and free), developed by Facebook. https://github.com/facebook/lexical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants