Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's kind of weird to got 2 same haptic feedbacks while a quick click #3

Closed
heshiyou opened this issue Jan 12, 2018 · 6 comments
Closed
Assignees

Comments

@heshiyou
Copy link
Contributor

Maybe it's a good idea to lower the up event's feedback intensity? Like, actuateActuationID = 1 for the up event?
I can do the PR.

@niw
Copy link
Owner

niw commented Jan 12, 2018

It triggers two haptic feedbacks when tap down and tap up. These are not exactly same as like how taps on trackpad trigger these. The one triggered for tap up has slightly different pattern.
See unknown3: used at https://github.com/niw/HapticKey/blob/master/HapticKey/Classes/HTKHapticFeedback.m#L52.

@heshiyou
Copy link
Contributor Author

I know, its quite good with a longer click, tap-pause-for-a-while-up, but when you do a quick tap, will get a weird ta-ta.
I changed the up event’s feedback intensity to weaker the second ‘ta’, it works ok.

@niw
Copy link
Owner

niw commented Jan 13, 2018

Okay, to me, it works even if it’s quick tap down and up. Probably, identifying each tap or key press and triggering timer to adjust intensity or wave form is the best solution but it may take some amount of work. Note this as enhancement and will work on it.

@heshiyou
Copy link
Contributor Author

Great, looking forward..

@niw niw self-assigned this Jan 14, 2018
@niw
Copy link
Owner

niw commented Jan 14, 2018

Implemented a timer guard to not trigger haptic feedback too much frequently in a commit b2b4ad2.
Released HapticKey 0.3.1.
This should mitigate double feedbacks in a short period.

@niw niw closed this as completed Jan 14, 2018
@heshiyou
Copy link
Contributor Author

Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants