Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Django 3.x #13

Closed
CuriousLearner opened this issue Apr 13, 2020 · 5 comments
Closed

Support Django 3.x #13

CuriousLearner opened this issue Apr 13, 2020 · 5 comments

Comments

@CuriousLearner
Copy link
Collaborator

Support for Django 3.x is to be added.

@justinmboucher
Copy link

justinmboucher commented Apr 15, 2020

From what I can tell the only thing that needs to change is in the utils.py file:

from django.contrib.staticfiles.templatetags.staticfiles import static as _static

Change to:

from django.templatetags.static import static as _static

Django 3 moved static templatetags to their builtin templatetags. So it throws a No module named: 'django.contrib.staticfiles.templatetags' exception if using the old implementation. Tested on my dev system, and it seems to work without any other issues now.

@CuriousLearner
Copy link
Collaborator Author

Hi @justinmboucher

Yes, the pull request that is attached to this issue handles this in the library. Please let me know what do you think about #12

@theskumar
Copy link
Contributor

The patch need to be merged and released @niwinz pinging on this.

@theskumar
Copy link
Contributor

@niwinz Just a friendly reminder. Would it be possible to merge and release this?

@CuriousLearner
Copy link
Collaborator Author

With #12 , this has been fixed.

0.11 is released on pypi: https://pypi.org/project/django-sites/0.11/ and tagged on git with https://github.com/niwinz/django-sites/releases/tag/0.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants