Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix VSCode Marketplace Integration #480

Closed
AmeerTaweel opened this issue Aug 27, 2022 · 5 comments
Closed

Nix VSCode Marketplace Integration #480

AmeerTaweel opened this issue Aug 27, 2022 · 5 comments

Comments

@AmeerTaweel
Copy link

Recently, I created nix-vscode-marketplace, a flake that includes the 10k most popular extensions from the VSCode Marketplace, and all the extensions of OpenVSX. @LEv145 suggested we integrate this into the NUR in this issue.

Do you think it's a good idea?

@Mic92
Copy link
Member

Mic92 commented Oct 9, 2022

Why not. What is the evaluation time for this repo?

@AmeerTaweel
Copy link
Author

Sorry for the late reply. I was inactive for the last period because of my university.

Can you please tell me how do we check evaluation time? I see there is a nix eval command. Should I use this?

@Mic92
Copy link
Member

Mic92 commented Dec 23, 2022

We currently have a timeout for running nix eval:

res = proc.wait(10)

$ time nix-env -qa '*' --xml --meta --drv-path -f ./default.nix

It is limited currently to 10s but this limit was chosen arbitrarily to prevent NUR from breaking when indexing random repositories.

@AmeerTaweel
Copy link
Author

Thanks.

I want to restructure this flake because the guys at nixos-search asked me to make the exported package set flat. Then I will evaluate it and report the results here.

@AmeerTaweel
Copy link
Author

It seems that nix-vscode-marketplace will be merged into nixpkgs. So I'm closing this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants