Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regeneration of Cargo.nix files for testing depends on local paths #47

Closed
kolloch opened this issue Nov 10, 2019 · 3 comments
Closed

Regeneration of Cargo.nix files for testing depends on local paths #47

kolloch opened this issue Nov 10, 2019 · 3 comments
Assignees
@kolloch
Milestone
0.8

Comments

@kolloch
Copy link
Collaborator

kolloch commented Nov 10, 2019

and thus cargo test can not be used independently from the host.

Super annoying. Mostly due to the "opaque" package IDs containing local paths, I think, but I need to analyze further.
@kolloch kolloch mentioned this issue Jan 26, 2020
Closed
@kolloch kolloch added this to To do in crate2nix 0.7 via automation Jan 27, 2020
@kolloch kolloch added this to the 0.7 milestone Jan 27, 2020
@kolloch kolloch self-assigned this Jan 27, 2020
@kolloch
Copy link
Collaborator Author

kolloch commented Feb 10, 2020

So, I have enabled vendoring for most of the tests. Unfortunately, for tests dependending on git repositories with submodules, the vendoring code in ./tools.nix still does not work so there are still a couple of pregenerated files in the repo.

That said, ./run_tests.sh should work for everyone and I can easily rerun it on each pull request before merging.

@kolloch kolloch removed this from the 0.7 milestone Feb 10, 2020
@kolloch kolloch removed this from To do in crate2nix 0.7 Feb 10, 2020
@kolloch
Copy link
Collaborator Author

kolloch commented Feb 12, 2020

I am fine with the current state of affairs for now.

@kolloch kolloch closed this as completed Feb 12, 2020
@kolloch
Copy link
Collaborator Author

kolloch commented Feb 18, 2020

Nah, I redecided since this is also an issue if you #102.

@kolloch kolloch reopened this Feb 18, 2020
@kolloch kolloch added this to the 0.8 milestone Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolloch kolloch

Labels
None yet
Projects
None yet
Milestone
0.8
Development

No branches or pull requests
1 participant
@kolloch