Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dconf2nix should invert special case for empty string lists #34

Closed
johanbrandhorst opened this issue May 23, 2021 · 2 comments · Fixed by #35
Closed

dconf2nix should invert special case for empty string lists #34

johanbrandhorst opened this issue May 23, 2021 · 2 comments · Fixed by #35

Comments

@johanbrandhorst
Copy link

The fix for nix-community/home-manager#769 introduced a special case for empty string lists when parsing the config. In short the following mapping happens:

[] -> @as []

See the logic here: nix-community/home-manager@5d054ab#diff-1afc90afe9ca8ef2ec31b8fcee765e03d38679506e051053848e4b14aed57bbaR22.

dconf2nix should invert this logic, so the following mapping happens:

@as [] -> []

Currently, this configuration value maps to

"@as []"

This mapping breaks keybindings which unset keys.

@johanbrandhorst
Copy link
Author

Thanks for the quick turnaround 😄

@gvolpe
Copy link
Collaborator

gvolpe commented May 23, 2021

No problems, you caught me at home with some time to kill :)

I cut a new release: https://github.com/gvolpe/dconf2nix/releases/tag/v0.0.8, should hit nixpkgs in a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants