Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

niv-updater-action without PR description #171

Closed
knl opened this issue Jan 14, 2022 · 4 comments
Closed

niv-updater-action without PR description #171

knl opened this issue Jan 14, 2022 · 4 comments

Comments

@knl
Copy link

knl commented Jan 14, 2022

Dear nix-community team,

I've noticed that you're running niv-updater-action without PR descriptions (the changelog). As I'm constantly looking to improve my software and help people, I'm wondering why you're doing it that way? Would you prefer to have something else in the PR description?

I've created an issue for your usecase: knl/niv-updater-action#51

Thanks,
Nikola

@zimbatm
Copy link
Member

zimbatm commented Jan 14, 2022

Hey Nikola,

It's probably just a taste thing. /cc @Mic92 to give you more context.

Thanks for building the action, it's nice.

@Mic92
Copy link
Member

Mic92 commented Jan 15, 2022

We used to log all PRs to our nix-community matrix channel and niv updater bumps were quite long and a bit spammy, which is why I removed the description. Now that we moved those messages to a dedicated monitoring channel we could potentially re-introduce them.

@Mic92
Copy link
Member

Mic92 commented Jan 16, 2022

fixed in d0de771

@Mic92 Mic92 closed this as completed Jan 16, 2022
@knl
Copy link
Author

knl commented Jan 17, 2022

Thanks for your kind words @zimbatm :)

Thanks for clarifying what was behind your change, and this issue didn't require any change. I was really just wondering what is the motivation to remove descriptions. I'll finish that change this week, so you can turn it off easily in case the need arises.

And final thanks for keeping the nix infra running :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants