feat: allow extra attributes that are transparently passed through #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we might not know yet the downstream contracts that we might want to satisfy in order to hand down package dependencies of a particular nixago pepple (keeping the domain's integrity). - therefore, make the request module a freefrom module that can take untyped additional arguments of type anything I tested in a downstream repo that the arguments are being passed along as expected in a repl: ``` nix-repl> tf = treefmt "x86_64-linux" nix-repl> tf. tf.commands tf.configData tf.format tf.output tf.packages nix-repl> tf.packages [ «derivation /nix/store/qgag2xc1s01jvr3x43r91q1025lv2cg8-alejandra-1.4.0.drv» «derivation /nix/store/v9ry51pyilwdkclx3gqq7vymn685z3hg-prettier-2.7.0.drv» «derivation /nix/store/k92vnq4jz3cigsrmn6z1h5b41rpylplm-prettier-plugin-toml-0.3.1.drv» «derivation /nix/store/kmbx2xn033vcr4iaica1kg3l62n7par9-shfmt-3.5.1.drv» «derivation /nix/store/irj6ps94b4icsjihck42617w15ncygf9-treefmt-0.4.1.drv» ] ``` closes: nix-community#29
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to satisfy in order to hand down package dependencies of a particular
nixago pepple (keeping the domain's integrity).
untyped additional arguments of type anything
I tested in a downstream repo that the arguments are being passed along
as expected in a repl:
closes: #29