Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add colors to nixago logs #48

Merged
merged 2 commits into from
Aug 30, 2022
Merged

feat: add colors to nixago logs #48

merged 2 commits into from
Aug 30, 2022

Conversation

blaggacao
Copy link
Contributor

closes: #47

@blaggacao blaggacao force-pushed the imp/add-colors branch 2 times, most recently from 56db27a to a5f6c4f Compare August 27, 2022 21:23
@blaggacao
Copy link
Contributor Author

That second commit still furthers style:

image

@blaggacao
feat: make log format configurable
ada4816 
adopt the direnv's mechanism
blaggacao
blaggacao commented Aug 28, 2022
View reviewed changes
Copy link
Contributor Author

@blaggacao blaggacao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went sideways while pushing...

All good: was a display issue on the GH cell phone app.

lib/hooks/ansi.nix Show resolved Hide resolved
@jmgilman
Copy link
Collaborator

Thanks for this :) I'll give it a look through later today and try to get it merged.

@jmgilman
Copy link
Collaborator

LGTM. Thanks for the PR!

@jmgilman jmgilman merged commit 8c1f9e5 into nix-community:master Aug 30, 2022
@github-actions github-actions bot mentioned this pull request Aug 30, 2022
Open
@blaggacao blaggacao deleted the imp/add-colors branch November 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add helpful colors to nixago logs
2 participants
@blaggacao @jmgilman