fix: Only update .gitignore when a link is indeed created #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you review this PR, please? @blaggacao |
|
Any blocker to merge this PR? |
blaggacao
approved these changes
Oct 6, 2023
|
It seems that you approved this pull request twice
…On Fri, Oct 6, 2023 at 4:45 PM David Arnold ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#56 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAES3OW2IVMDTZV6BRXX333X6CJY7AVCNFSM6AAAAAA2C6TZQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNRSHEYTCNBSGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@blaggacao Could you merge this PR, please? |
|
Is this project still actively maintained by @jmgilman? If no, @blaggacao do you want to maintain this project? |
|
Yeah, based on the knowledge of the codebase and downstream dependencies that I co-maintain, I could take maintainership, if desired. |
|
Thank you! Do you want to create a post to request the permission here: https://github.com/orgs/nix-community/discussions |
|
I'd be happy to transfer maintainership to @blaggacao. We no longer utilize this in our stack so it will be hard for me to keep up with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make sense to update
.gitignoreif there is an existing manually created file