Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nord colorscheme not starting on launch due to colorscheme not set when colorschemes.nord.enable = true; #1189

Closed
1 task done
stepbrobd opened this issue Mar 2, 2024 · 4 comments · Fixed by #1192
Closed
1 task done
Assignees
Labels
bug Something isn't working

Comments

@stepbrobd
Copy link

Field Description
Plugin nord
Nixpkgs unstable
Home Manager unstable
  • I have read the FAQ and my bug is not listed there.

Description

nord was switched to mkVimPlugin but it should be colorscheme

introduced in: be87309

related issue: #941

@stepbrobd stepbrobd added the bug Something isn't working label Mar 2, 2024
@GaetanLepage
Copy link
Collaborator

In what sense is it broken ?
The current implementation should not have a different effect than the previous one, which is to set some global values (vim.g.nord_*). Was it doing something more before ? Should it do something differently ?

We now use the mkVimPlugin helper but the namespace is properly set to colorschemes.

@GaetanLepage GaetanLepage self-assigned this Mar 2, 2024
@stepbrobd
Copy link
Author

Ah, this is caused by colorscheme = "nord"; was removed in this commit

Thus, in https://github.com/nix-community/nixvim/blob/main/modules/colorscheme.nix#L17, colorscheme is not set, causing nord not starting on launch

@stepbrobd stepbrobd changed the title nord theme broken nord colorscheme not starting on launch due to colorscheme not set when colorschemes.nord.enable = true; Mar 2, 2024
@GaetanLepage
Copy link
Collaborator

Ah, this is caused by colorscheme = "nord"; was removed in this commit

Thus, in https://github.com/nix-community/nixvim/blob/main/modules/colorscheme.nix#L17, colorscheme is not set, causing nord not starting on launch

Indeed, thanks for finding out this bug !

@stepbrobd
Copy link
Author

I'm not sure if the mkVimPlugin rewrite affected other colorschemes plugins tho, it might be better to take another look for those plugins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants