Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN REQUEST] improved-search.nvim #1338

Closed
PowerUser64 opened this issue Mar 28, 2024 · 4 comments · Fixed by #1411
Closed

[PLUGIN REQUEST] improved-search.nvim #1338

PowerUser64 opened this issue Mar 28, 2024 · 4 comments · Fixed by #1411
Labels
enhancement New feature or request

Comments

@PowerUser64
Copy link

Field Description
Plugin improved-search.nvim
Homepage github:backdround/improved-search.nvim
Nixpkgs false

Extra Information

Would be nice to have options to enable some (or all) of the suggested configuration options presented in the readme, as I think most people will use it in this way.

@PowerUser64 PowerUser64 added the enhancement New feature or request label Mar 28, 2024
@GaetanLepage
Copy link
Member

Made a PR to nixpkgs: NixOS/nixpkgs#299697

@PowerUser64
Copy link
Author

Woah cool, how'd you do that? I see that pkgs/applications/editors/vim/plugins/generated.nix is modified in the PR, but I'm guessing that was generated from pkgs/applications/editors/vim/plugins/vim-plugin-names? What did you do to generate it?

@GaetanLepage
Copy link
Member

GaetanLepage commented Mar 28, 2024

The first step is to add the plugin to vim-plugin-names.
This can be done by running:

nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater add OWNER/PLUGIN_REPO'

Then, the generated.nix file has to be populated with the new plugin.
Theoretically, you should do it by running the script without argument.

nix-shell -p vimPluginsUpdater --run 'vim-plugins-updater'

This will update the entire generated.nix file according to the vim-plugin-names list.
In practice, I prefer manually writing the snippet corresponding to my plugin in generated.nix.
Indeed, running the update script updates all the plugins, which requires a github token and a lot of time (~15min) to run.
Also, it is better for PRs that aim at adding a new plugin to do just that, without the risk of introducing a regression caused by a plugin update.

Resources: https://nixos.org/manual/nixpkgs/stable/#adding-new-plugins-to-nixpkgs

@PowerUser64
Copy link
Author

Woah, cool! Thanks for explanation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants