Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev docs #214

Merged
merged 35 commits into from Dec 7, 2021
Merged

Dev docs #214

merged 35 commits into from Dec 7, 2021

Conversation

lapp0
Copy link
Collaborator

@lapp0 lapp0 commented Nov 25, 2021 •
edited

fixes #188

Important for review: Architecture documented

Minor changes:

  • development.org reorganized into multiple files,
  • FieldsGroupBox refactored out of nav_interface.py

This documentation describes the state of Nix-Gui after the following issues are tackled:

@lapp0 lapp0 changed the title WIP: Dev docs Dev docs Dec 2, 2021
@lapp0
Copy link
Collaborator Author

lapp0 commented Dec 2, 2021

@milahu @boredom101

Could you please review? If anything doesn't make sense, worded weirdly, incoherent, etc please request a change.

milahu
milahu reviewed Dec 2, 2021
View reviewed changes
docs/development/goals.org Outdated Show resolved Hide resolved
This was referenced Dec 2, 2021
Open
Open
@lapp0 lapp0 mentioned this pull request Dec 7, 2021
Open
@lapp0
Copy link
Collaborator Author

lapp0 commented Dec 7, 2021

@milahu hows this?

@milahu
Copy link
Contributor

milahu commented Dec 7, 2021

For =types.attrsOf= options, users can specify their attributes.

how is this useful? → give names to things: file names, user names, service names (myHttpServer1)

@lapp0
Copy link
Collaborator Author

lapp0 commented Dec 7, 2021

This any better?

@milahu
Copy link
Contributor

milahu commented Dec 7, 2021

better, thanks. the wording could be shorter, but meh, people will understand

@lapp0
Copy link
Collaborator Author

lapp0 commented Dec 7, 2021

Sure thing, we will continue to update architecture.org as we move forward. Thanks for reviewing.

@lapp0 lapp0 merged commit c77ba77 into master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milahu milahu milahu left review comments

@boredom101 boredom101 boredom101 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Developer Docs
3 participants
@lapp0 @milahu @boredom101