Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SwapNamesUpdate Business Logic to OptionTree #260

Open
lapp0 opened this issue Dec 31, 2021 · 0 comments
Open

Move SwapNamesUpdate Business Logic to OptionTree #260

lapp0 opened this issue Dec 31, 2021 · 0 comments
Milestone
V0.3 - Edge Case ...

Comments

@lapp0
Copy link
Collaborator

lapp0 commented Dec 31, 2021

Currently StateModel hackily handles swap_options by calling OptionTree.rename_attribute three times, once using a "placeholder" attribute that is recorded to the tree then ignored. This placeholder shouldn't exist and instead swap_options should call a new method OptionTree.swap_attributes. Same for SwapNamesUpdate.revert.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V0.3 - Edge Case Handing, Fix Some Mi...
Development

No branches or pull requests
1 participant
@lapp0