Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for new release? #178

Closed
tailhook opened this issue Aug 26, 2015 · 6 comments
Closed

Any plans for new release? #178

tailhook opened this issue Aug 26, 2015 · 6 comments

Comments

@tailhook
Copy link
Contributor

In particular I'm interested in waitpid and clone functions which were recently fixed. I'm asking because it blocks releasing of my unshare crate which deals with linux containers.

@agrover
Copy link
Contributor

agrover commented Aug 28, 2015

ioctls appear to be inoperative at the moment.

@carllerche
Copy link
Contributor

@agrover what do you mean?

@agrover
Copy link
Contributor

agrover commented Aug 28, 2015

@carllerche on further examination I am wrong, I guess ioctl! actually is what calls ioctl() now, and no doubt it works 😄

But some more documentation and examples around ioctl! would be great. I see how iorw!() and friends map to what was in 0.3.9, but converting read_into(x) and read_into_ptr(x) calls into ioctl!(x) is not at all clear to me, or documented as well as the old way was.

(tailhook sorry for hijacking your bug)

@posborne
Copy link
Member

@agrover, I can work on improving the documentation. For now, here's a couple pieces of code I have started to put together using the new macros:

To be honest, I have somewhat mixed feelings about the new macros. I think they are better in some ways but there will likely need to be some improvement on them over time to get things where they should be long term. Feedback, changes welcome.

I'm not sure how best to approach other platforms either. Some research will be required. I think it would be good to make something like the current "bad" version of the ioctl! macro available on all platforms.

@agrover
Copy link
Contributor

agrover commented Aug 28, 2015

@posborne thanks that'll get me started!

@carllerche
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants