Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illogical return value for SockaddrIn::ip() when compared with SockaddrIn6::ip() #2003

Closed
hauleth opened this issue Feb 20, 2023 · 2 comments · Fixed by #2151
Closed

Illogical return value for SockaddrIn::ip() when compared with SockaddrIn6::ip() #2003

hauleth opened this issue Feb 20, 2023 · 2 comments · Fixed by #2151

Comments

@hauleth
Copy link

hauleth commented Feb 20, 2023

One returns in_addr_t which is integer value while other returns std::net::Ipv6Addr. It feels weird that for one type we need to do additional work to change in_addr_t to std::net::Ipv4Addr which seems counterintuitive as it is not needed for SockaddrIn6.

@asomers
Copy link
Member

asomers commented Feb 26, 2023

You're right; that's inconsistent. Have you done the git archaeology to figure out how it got that way?

@hauleth
Copy link
Author

hauleth commented Mar 7, 2023

No, I have not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants