Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain trailing slash in reverse-proxy location entry #32

Closed
CrushedPixel opened this issue May 29, 2018 · 1 comment
Closed

Retain trailing slash in reverse-proxy location entry #32

CrushedPixel opened this issue May 29, 2018 · 1 comment

Comments

@CrushedPixel
Copy link

Currently, the nginx config generated by the reverse-proxy abstraction does not properly translate path settings into location entries - in my particular case, I need a trailing slash in the location entry to only match subroutes of a given path.

Expected behaviour:

path = "/api/" generates location /api/

Observed behaviour:

path = "/api/" generates location /api

I didn't check, but there could be more functionality affected by this issue (for example regexes), so the path setting should be translated into the location entry as closely as possible.

@CrushedPixel
Copy link
Author

CrushedPixel commented May 29, 2018

Fixed in 211b0a3.
Leaving this open for @qknight to think about implications of this change, for example the previous removal of double slashes in the path being disabled.

@qknight qknight closed this as completed Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants