Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tests #66

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Fixed tests #66

merged 1 commit into from
Feb 7, 2017

Conversation

AdrianSkierniewski
Copy link
Contributor

Hi,

I fixed some failing tests. Laravel 5.3 is using more function from PDOStatement, and we weren't' mocking them.

@coveralls
Copy link

coveralls commented Jan 20, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 82.867% when pulling 0aa4e58 on AdrianSkierniewski:fixed_tests into 5af1d26 on njbarrett:master.

@njbarrett njbarrett merged commit ae7087c into mstaack:master Feb 7, 2017
@njbarrett
Copy link
Collaborator

Thanks very much!

@njbarrett
Copy link
Collaborator

@AdrianSkierniewski not sure why, but we're still getting failures on master :/

@AdrianSkierniewski
Copy link
Contributor Author

AdrianSkierniewski commented Feb 7, 2017 •
edited
Loading

@njbarrett I'll check this later but probably it is related to recent release of Laravel 5.4 (I only fixed this for 5.3 :))

@AdrianSkierniewski AdrianSkierniewski deleted the fixed_tests branch February 7, 2017 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@AdrianSkierniewski @coveralls @njbarrett