Handle locales where <? (string) 1.32 // 1,32 ?>

[FelixMalfait]

setlocale(LC_ALL,'fr_FR.utf8');
(string) 1.32; // return 1,32

PHP's __toString on floats converts it to the user's locale.
The comma will then cause a database error.

[coveralls]

Coverage increased (+0.7%) to 84.639% when pulling ebc8cea on FelixMalfait:patch-1 into 65ae484 on njbarrett:master.

[njbarrett]

Thanks for this

[njbarrett]

Actually this seems to have broken the tests, are you able to update the tests to pass?

[FelixMalfait]

Yes I saw this sorry, will have a look today :)
(test broken not because it breaks anything but rather because of the way tests were written)

[FelixMalfait]

In the end this is actually much more work than I thought.
The underlying issue is that you're converting the arguments to string instead of using the argument replace feature of the sql driver. This probably has some other side effects like making users of this package vulnerable to SQL injections.
@challet is trying to work on this now, we'll keep you updated :)
Many thanks for your work on this package, not trying to come and criticise your work ;), just opening a discussion