Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About client_postval #390

Open
nopnop2002 opened this issue May 24, 2020 · 0 comments
Open

About client_postval #390

nopnop2002 opened this issue May 24, 2020 · 0 comments

Comments

@nopnop2002
Copy link

nopnop2002 commented May 24, 2020

Thank you for great wrok.

I have a small problem.

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L47

 static const char *client_postval;

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L542

    if (client_postval == 0) {

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L562

                     strlen(client_postval),

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L588

client_postval = 0;

https://github.com/njh/EtherCard/blob/master/src/tcpip.cpp#L597

client_postval = postval;

These code may cause an error in the future.

client_postval = 0; --> client_postval = "";

if (client_postval == 0) --> if (strlen(client_postval) == 0)

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant