Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nfr] Support for pcap@3 #4

Open
ruudboon opened this issue May 14, 2020 · 3 comments · May be fixed by #5
Open

[nfr] Support for pcap@3 #4

ruudboon opened this issue May 14, 2020 · 3 comments · May be fixed by #5

Comments

@ruudboon
Copy link

Currently the default install fails since pcap 3 is been used. Could you add support for this?
@njh
Copy link
Owner

njh commented May 14, 2020

Ooh, I kind of gave up on this because I was finding pcap so unstable and new versions / fixes weren't getting released.

Fingers crossed v3 makes everything better 🤞

@ruudboon
Copy link
Author

@njh Trying to get it working now. Want me to drop a pull on this? Looks like it's broken in the first place since it's trying to include pcap2 instead of pcap

@njh
Copy link
Owner

njh commented May 14, 2020

Yeah, it was loading pcap2 (https://github.com/andygreenegrass/node-pcap) because of the lack of releases of the official version.

A Pull Request would be very welcome.

@ruudboon ruudboon linked a pull request May 14, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade pcap, workaround pcap issue. ruudboon/node-red-contrib-pcap
2 participants
@njh @ruudboon