Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trouble when doing cmake in Windows #86

Closed
WenyinWei opened this issue May 19, 2019 · 10 comments
Closed

Trouble when doing cmake in Windows #86

WenyinWei opened this issue May 19, 2019 · 10 comments

Comments

@WenyinWei
Copy link

Hello guys,

Nice to see Los Alamos National Laboratory's excellent work on helping people with their data. I met some troubles when installing NJOY, any volunteer willing to help?

fatal: not a git repository: C:/NJOY21/subprojects/catch-adapter/../../../../.git/modules/dependencies/dimwits/modules/dependencies/catch-adapter
fatal: not a git repository: C:/NJOY21/subprojects/disco/../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/disco                                                                                                             
fatal: not a git repository: C:/NJOY21/subprojects/fmt-adapter/../../../../../../../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/header-utilities/modules/dependencies/Log/modules/dependencies/spdlog-adapter/modules/dependencies/fmt-adapter                                                                                                       
fatal: not a git repository: C:/NJOY21/subprojects/hana-adapter/../../../../.git/modules/dependencies/dimwits/modules/dependencies/hana-adapter                                                                                                 
fatal: not a git repository: C:/NJOY21/subprojects/header-utilities/../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/header-utilities                                                                                          
fatal: not a git repository: C:/NJOY21/subprojects/hopscotch-map-adapter/../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/hopscotch-map-adapter                                                                                
fatal: not a git repository: C:/NJOY21/subprojects/Log/../../../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/header-utilities/modules/dependencies/Log                                                                        
fatal: not a git repository: C:/NJOY21/subprojects/njoy/../../../../.git/modules/dependencies/njoy_c_bindings/modules/dependencies/njoy                                                                                                         fatal: not a git repository: C:/NJOY21/subprojects/range-v3-adapter/../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/range-v3-adapter                                                                                          
fatal: not a git repository: C:/NJOY21/subprojects/spdlog-adapter/../../../../../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/header-utilities/modules/dependencies/Log/modules/dependencies/spdlog-adapter                   fatal: not a git repository: C:/NJOY21/subprojects/utility/../../../../.git/modules/dependencies/lipservice/modules/dependendices/utility                                                                                                       fatal: not a git repository: C:/NJOY21/subprojects/variant-adapter/../../../../.git/modules/dependencies/ENDFtk/modules/dependencies/variant-adapter                                                                                            
fatal: not a git repository: C:/NJOY21/subprojects/catch-adapter/../../../../.git/modules/dependencies/dimwits/modules/dependencies/catch-adapter                                                                                               fatal: not a git repository: C:/NJOY21/subprojects/catch-adapter/../../../../.git/modules/dependencies/dimwits/modules/dependencies/catch-adapter               

I can almost make sure that the problem was caused by such lines in CMakelists of subprojects:

........
project( catch-adapter LANGUAGES CXX )
.........
 execute_process(
     COMMAND ${GIT_EXECUTABLE} rev-parse --abbrev-ref HEAD
     WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
     OUTPUT_VARIABLE GIT_BRANCH
     OUTPUT_STRIP_TRAILING_WHITESPACE
)
 execute_process(
     COMMAND ${GIT_EXECUTABLE} rev-parse HEAD
     WORKING_DIRECTORY ${PROJECT_SOURCE_DIR}
     OUTPUT_VARIABLE GIT_HASH
     OUTPUT_STRIP_TRAILING_WHITESPACE
) 

, I guess the problem only exists for Windows because Linux handle Git commands very naturally.

Thanks in advance,
Wenyin

@jlconlin
Copy link
Member

@WenyinWei Can you give me more information about the process you went through to get these errors? We've built NJOY21 on Windows and haven't seen this before. Keep in mind that we only support installing/building NJOY21 (or NJOY2016) using Windows Subsystem for Linux.

@WenyinWei
Copy link
Author

@jlconlin Thank you jlconlin, I didn't compile it on Windows Subsystem but by MinGW. It seems that the compatibility problem would deadly limit its usage on Windows platform while embedding parts of NJOY(e.g. parsing ENDF file) into a Windows software. Do you have any good suggestions to settle the problem?

Thanks,
Wenyin

@jlconlin
Copy link
Member

@WenyinWei Windows Subsystem for Linux (WSL) is available for every Windows 10 machine for free and works well. We would like to make this native on Windows, but don't currently have the resources. For now WSL seems to be the way to go.

@WenyinWei
Copy link
Author

Could any part of NJOY works as a third party header in windows app? This is good enough but relies on mature modulization organization.

@jlconlin
Copy link
Member

Not at this time, no.

@kahlerac
Copy link

kahlerac commented May 20, 2019 via email

@paulromano
Copy link
Member

@WenyinWei If you are looking for something for working with ENDF/ACE files, you may want to look at others projects too. OpenMC has a data module that can give you access to data within ENDF files through Python classes. Fudge also has similar functionality. Both of those are written primarily in Python and may be easier to integrate into a Windows app.

@WenyinWei
Copy link
Author

Thanks for all of your warm reply. I would try some of these tools someday and report the best choice.

@apmccartney
Copy link
Member

apmccartney commented May 22, 2019

... embedding parts of NJOY(e.g. parsing ENDF file) into a Windows software.

Could any part of NJOY works as a third party header in windows app? This is good enough but relies on mature modulization organization.

NJOY21 defers ENDF processing to a independent software library called ENDFtk, which is not specific to the NJOY21 application and can be (and has been) used in the context of other applications

@apmccartney
Copy link
Member

Regarding the error you encountered can you tell us a bit more about the environment your working in and walk through the steps you took to clone and build NJOY21?

@jlconlin jlconlin closed this as completed Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants