New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discuss basic guidelines #6

Open

nkint opened this issue Jun 11, 2020 · 1 comment

Owner

nkint commented Jun 11, 2020

Some basic guidelines to write components like:

Each component should export a <div> ?
Each component should use forward ref ?
Additional props for style (color, spaces, radii) or just use theme?

etc

The text was updated successfully, but these errors were encountered:

Collaborator

dbertella commented Jun 11, 2020

I don't know exactly, why a div?
I think it should forward ref, but we should read / ask about it
use theme-ui we don't want to reinvent the wheel the cool thing is this will be on top of theme-ui, so wathever works there should work in our lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment