Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Electron 7 #555

Closed
ethernomad opened this issue Nov 18, 2019 · 12 comments
Closed

Support Electron 7 #555

ethernomad opened this issue Nov 18, 2019 · 12 comments

Comments

@ethernomad
Copy link

Electron 7 has been released:

https://electronjs.org/releases/stable

@ethernomad
Copy link
Author

Actually - it is supported - it's just not in the wizard.

@xland
Copy link

xland commented Nov 19, 2019

No. It is not supported.
See #540 #546

@nklayman
Copy link
Owner

Electron 7 works fine with this plugin (except for #546, but that is quite minor). I don't have it available in the wizard because of issues with spectron. Feel free to use it in you apps (as long as you aren't using spectron).

@xland
Copy link

xland commented Nov 20, 2019

Thanks

@pacific202
Copy link

How do you enable Electron v7? Is it just a matter of installing with v6 then changing the electron entry in package.json and running npm install?

@nklayman
Copy link
Owner

Yep, as long as you don't use spectron that works fine.

@bluelovers
Copy link

is spectron mean vue-cli-service electron:serve ?

@nklayman
Copy link
Owner

nklayman commented Dec 7, 2019

No, spectron is a e2e testing framework for electron.

@hgt803
Copy link

hgt803 commented Dec 18, 2019

throw new Error('Electron failed to install correctly, please delete node_modules/electron and try installing again')

electron/electron#20994 (comment)

@alexhx5
Copy link

alexhx5 commented Dec 22, 2019

@nklayman please keep in mind Electron 7.x no longer uses the electron.asar file. Perhaps some changes will need to be made in vue-cli-plugin-electron-builder to adapt to that change.

Also, do you have a specific date in mind for the release that supports Electron 7.x (which is gonna be 2.0.0 I assume) or at least an approximate date?

@hgt803
Copy link

hgt803 commented Dec 30, 2019

@nklayman please keep in mind Electron 7.x no longer uses the electron.asar file. Perhaps some changes will need to be made in vue-cli-plugin-electron-builder to adapt to that change.

Also, do you have a specific date in mind for the release that supports Electron 7.x (which is gonna be 2.0.0 I assume) or at least an approximate date?

i fix it use yarn upgrade

@nklayman
Copy link
Owner

nklayman commented Jan 9, 2020

v2.0.0 beta supports electron 7.

@nklayman nklayman closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants