Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat with yarn berry #43

Closed
birkskyum opened this issue Dec 26, 2023 · 4 comments · Fixed by #60
Closed

compat with yarn berry #43

birkskyum opened this issue Dec 26, 2023 · 4 comments · Fixed by #60

Comments

@birkskyum
Copy link
Contributor

birkskyum commented Dec 26, 2023

using solid start with yarn berry result in module resolution issues with jiti, through vinxi:

repro:

  • yarn create solid
  • select bare (important step that is the bare template)
  • yarn set version berry (to use yarn v4)
  • yarn
  • yarn dev
@nksaraf
Copy link
Owner

nksaraf commented Dec 27, 2023

you have any idea what might be wrong? I havent use yarn (or berry) in a very long time.

@birkskyum
Copy link
Contributor Author

birkskyum commented Dec 27, 2023

yes, i believe @danieltroger managed to narrow it down quite a lot in here solidjs/solid-start#1177 (comment) . I wonder if it's just vinxi, or if any use of jiti with yarn berry is problematic, and the issue thus should be moved upstream.

@pi0
Copy link
Contributor

pi0 commented Jan 16, 2024

Some notes here: unjs/jiti#204 (comment)

TLDR: I think vinxi can help to resolve complexity of situation by preferring type: "module" + "default" condition also seems more pnp issues with @solid/start

@nksaraf
Copy link
Owner

nksaraf commented Jan 17, 2024

Type module is already there I think. Default condition for what? All the exports ? Sure I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants