Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Plain-text template #1

Merged
merged 12 commits into from
Apr 8, 2013
Merged

Feature: Plain-text template #1

merged 12 commits into from
Apr 8, 2013

Conversation

r-a-y
Copy link
Contributor

@r-a-y r-a-y commented Feb 14, 2013

Hi Nicolas,

Got your email. I've added my changes to this pull request.

The main changes are:

  • Adding a plain-text template option on the admin settings page
  • Making sure we can use our plain-text template when sending - check out the send_email_template(), send_html() and validate_options() methods
  • Adding two filters to the plain-text and HTML body - 'wpbe_plaintext_body' and 'wpbe_html_body' - this will be useful for plugin devs so they can modify the email contents before sending
  • Formatted the code to use WP's coding standards - https://codex.wordpress.org/WordPress_Coding_Standards

Let me know if you have any questions!

* Adds a second parameter so we can use different templates later on.
* This will be used so we can set our plain-text template during sending.
* Use our modified set_email_template() to set the 'AltBody' variable with our plain-text template
* Add filters to the plain-text body and HTML body so plugins can alter the contents of the email before WPBE sends out the email.
* Validates 'plaintext_template' option
* Formats method with whitespace as per WP coding standards - https://codex.wordpress.org/WordPress_Coding_Standards#Space_Usage
nlemoine added a commit that referenced this pull request Apr 8, 2013
Feature: Plain-text template
@nlemoine nlemoine merged commit 08614d2 into nlemoine:master Apr 8, 2013
@r-a-y
Copy link
Contributor Author

r-a-y commented Apr 8, 2013

Thanks for merging in my changes, nlemoine!

@nlemoine
Copy link
Owner

nlemoine commented Apr 9, 2013

@r-a-y You're welcome, thank you for your help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants