Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching on token after refresh fails #12

Closed
ThomasArts opened this issue May 27, 2020 · 4 comments
Closed

Matching on token after refresh fails #12

ThomasArts opened this issue May 27, 2020 · 4 comments

Comments

@ThomasArts
Copy link
Contributor

I assume that matching on Token in:

{ok, Token} = call_remote({refresh_token, Credentials}),

is aimed to be an assignment instead. If we get a new token returned from call_remote({refresh_token, Credentials}), different from Token, then this gives a badmatch.

Instead one should use FreshToken as variable.

@nlfiedler
Copy link
Owner

That is almost certainly a copy/paste error on my part, and by dumb luck never ran into that case (or apparently noticed when it did). I don't have a build setup any more, so if you want to submit a PR, please feel free. Thanks.

@philipcristiano
Copy link

Can this be tagged as well? I ran into this using the 0.4.0 tag.

@nlfiedler
Copy link
Owner

Oh shoot, and this was fixed months ago, too. I've just added the tag, sorry about that.

@philipcristiano
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants