Exhaust training set #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when the `len(trX)` is completely divisible by `batch_size`, the training skipped over the last batch because `end=len(trX)` would never occur. Corrected this and now the loop will go over the entire training set if `batch_size` can cleanly fit in.
|
I think this looks good. Can you take a look @hunkim |
|
+1. @eywalker We have the same code in other files. Do you have time to fix them as well? |
|
Sure - I'll do a quick scan. |
|
Wonderful! Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when the
len(trX)is completely divisible bybatch_size, the training skipped over the last batch becauseend=len(trX)would never occur. Corrected this and now the loop will go over the entire training set ifbatch_sizecan cleanly fit in.