Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local files parsing Error #92

Closed
juanls1 opened this issue Jul 9, 2024 · 2 comments
Closed

Local files parsing Error #92

juanls1 opened this issue Jul 9, 2024 · 2 comments

Comments

@juanls1
Copy link

juanls1 commented Jul 9, 2024

In line 63 of llmsherpa/readers/file_reader.py it should not be =! “c” instead of =! “”?

@aaryan200
Copy link
Collaborator

aaryan200 commented Aug 12, 2024

I think it should be this:

is_url = (urlparse(path_or_url).scheme in ["http", "https"])

This is because your solution won't work for linux type file system (urlparse("/home/username/a.pdf") = "").

Could you change that in your PR?

@juanls1
Copy link
Author

juanls1 commented Aug 12, 2024

Thanks aaryan200, I have changed the PR accordingly

@juanls1 juanls1 closed this as completed Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants