Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simVpc needs to more closely match the estimated model #306

Closed
mattfidler opened this issue Jan 11, 2023 · 2 comments · Fixed by #308
Closed

simVpc needs to more closely match the estimated model #306

mattfidler opened this issue Jan 11, 2023 · 2 comments · Fixed by #308

Comments

@mattfidler
Copy link
Member

There is a case where the vpcSim does not match the estimated model as well as using the $foceiModel$predOnly to do the vpc. This means the vpcSim needs to be updated to more closely match the focei and other sorts of models...

@mattfidler
Copy link
Member Author

This also probably means assigning the simulation model to fit$ui$.simulationModel in the appropriate context

See below:

https://github.com/nlmixr2/rxode2/blob/efcee1c8412d0ce098dc760237f317ae9b363e76/R/err-sim.R#L225-L233

@mattfidler
Copy link
Member Author

Also see:

.getSimModel <- function(obj, hideIpred=FALSE, tad=TRUE) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant