Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump() now uses InternalLogger.Debug() consistent #1001

Merged
merged 1 commit into from
Oct 25, 2015
Merged

Dump() now uses InternalLogger.Debug() consistent #1001

merged 1 commit into from
Oct 25, 2015

Conversation

ie-zero
Copy link
Contributor

@ie-zero ie-zero commented Oct 25, 2015

Dump() method in LoggingConfiguration documented and changed to consistently use InternalLogger.Debug() method for output. When debug level is disabled no info level details will be recorded anyway as Debug < Info.

Dump() now uses InternalLogger.Debug() consistent
6fd034a 
Dump() method in LoggingConfiguration changed to consistently use
InternalLogger.Debug() method for output. When debug level is disabled
no info level details will be recorded anyway as Debug < Info.
Dump() method in LoggingConfiguration also documented.
@codecov-io
Copy link

Current coverage is 71.54%

Merging #1001 into master will not affect coverage as of fed7a84

@@            master   #1001   diff @@
======================================
  Files          262     262       
  Stmts        14793   14793       
  Branches      1611    1611       
  Methods          0       0       
======================================
  Hit          10584   10584       
  Partial        417     417       
  Missed        3792    3792

Review entire Coverage Diff as of fed7a84

Uncovered Suggestions

  1. +0.08% via ...c/NLog/LogFactory.cs#180...191
  2. +0.08% via ...anceCounterTarget.cs#308...318
  3. +0.08% via ...anceCounterTarget.cs#294...304
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Oct 25, 2015
@304NotModified 304NotModified added this to the 4.3 milestone Oct 25, 2015
304NotModified added a commit that referenced this pull request Oct 25, 2015
@304NotModified
Merge pull request #1001 from ie-zero/LoggingConfig-DumpMethod
cf229c3 
Dump() now uses InternalLogger.Debug() consistent
@304NotModified 304NotModified merged commit cf229c3 into NLog:master Oct 25, 2015
@304NotModified
Copy link
Member

Thanks again!

@ie-zero ie-zero deleted the LoggingConfig-DumpMethod branch October 25, 2015 19:53
@304NotModified 304NotModified modified the milestones: 4.3, 4.2.1 Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ie-zero @codecov-io @304NotModified