Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logbuilder tests + fix passing Off #1036

Merged
merged 3 commits into from
Nov 12, 2015
Merged

Logbuilder tests + fix passing Off #1036

merged 3 commits into from
Nov 12, 2015

Conversation

304NotModified
Copy link
Member

No description provided.

@304NotModified 304NotModified added enhancement Improvement on existing feature has unittests labels Nov 12, 2015
@codecov-io
Copy link

Current coverage is 72.37%

Merging #1036 into master will increase coverage by +0.24% as of 60f5f37

@@            master   #1036   diff @@
======================================
  Files          263     263       
  Stmts        14834   14840     +6
  Branches      1610    1612     +2
  Methods          0       0       
======================================
+ Hit          10700   10740    +40
+ Partial        419     416     -3
+ Missed        3715    3684    -31

Review entire Coverage Diff as of 60f5f37

Uncovered Suggestions

  1. +0.08% via ...argets/FileTarget.cs#1918...1930
  2. +0.08% via ...argets/FileTarget.cs#1555...1567
  3. +0.08% via ...c/NLog/LogFactory.cs#180...191
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added this to the 4.2.1 milestone Nov 12, 2015
304NotModified added a commit that referenced this pull request Nov 12, 2015
@304NotModified
Merge pull request #1036 from NLog/logbuilder-tests
7fc86d8 
Logbuilder tests + fix passing Off
@304NotModified 304NotModified merged commit 7fc86d8 into master Nov 12, 2015
@304NotModified 304NotModified deleted the logbuilder-tests branch November 16, 2015 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io