Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved sourcecode tests to separate tool #1043

Merged
merged 9 commits into from
Nov 16, 2015

Conversation

304NotModified
Copy link
Member

  • Removes false positives in code covage
  • No need to run 3 times
  • Clearer errors
  • No need to use xUnit or nUnit for this
  • Prepared for usage in other repositories

@codecov-io
Copy link

Current coverage is 72.91%

Merging #1043 into master will decrease coverage by -0.42% as of 3801913

@@            master   #1043   diff @@
======================================
  Files          263     263       
  Stmts        14873   14873       
  Branches      1617    1617       
  Methods          0       0       
======================================
- Hit          10907   10845    -62
  Partial        416     416       
- Missed        3550    3612    +62

Review entire Coverage Diff as of 3801913


Uncovered Suggestions

  1. +0.09% via ...argets/FileTarget.cs#1918...1930
  2. +0.09% via ...argets/FileTarget.cs#1555...1567
  3. +0.08% via ...c/NLog/LogFactory.cs#180...191
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Nov 15, 2015
304NotModified added a commit that referenced this pull request Nov 16, 2015
Moved sourcecode tests to separate tool
@304NotModified 304NotModified merged commit e11ec9b into master Nov 16, 2015
@304NotModified 304NotModified added this to the 4.2.1 milestone Nov 16, 2015
@304NotModified 304NotModified deleted the fix-annoying-sourcecodetests branch November 16, 2015 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants