Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Var layout renderer improvements #1048

Merged
merged 4 commits into from
Nov 18, 2015
Merged

Var layout renderer improvements #1048

merged 4 commits into from
Nov 18, 2015

Conversation

304NotModified
Copy link
Member

Fixes #1047

  • Needs test case for custom logmanager

@codecov-io
Copy link

Current coverage is 72.92%

Merging #1048 into master will increase coverage by +0.01% as of bccd470

@@            master   #1048   diff @@
======================================
  Files          263     263       
  Stmts        14873   14875     +2
  Branches      1617    1618     +1
  Methods          0       0       
======================================
+ Hit          10845   10847     +2
  Partial        416     416       
  Missed        3612    3612

Review entire Coverage Diff as of bccd470

Uncovered Suggestions

  1. +0.08% via ...argets/FileTarget.cs#1918...1930
  2. +0.08% via ...argets/FileTarget.cs#1555...1567
  3. +0.08% via ...c/NLog/LogFactory.cs#180...191
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
added test with custom logmanager
bccd470 
confirmed it's not working with NLog 4.2.0 (this change is for NLog
4.2.1)
@304NotModified 304NotModified added enhancement Improvement on existing feature and removed work in progress labels Nov 18, 2015
@304NotModified 304NotModified added this to the 4.2.1 milestone Nov 18, 2015
304NotModified added a commit that referenced this pull request Nov 18, 2015
@304NotModified
Merge pull request #1048 from NLog/var-layout-renderer-improvements
b76c16d 
Var layout renderer improvements
@304NotModified 304NotModified merged commit b76c16d into master Nov 18, 2015
@304NotModified 304NotModified deleted the var-layout-renderer-improvements branch November 18, 2015 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io