Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LogReceiverWebServiceTarget.CreateLogReceiver() should be virtual #1054

Merged
merged 1 commit into from Nov 18, 2015
Merged

LogReceiverWebServiceTarget.CreateLogReceiver() should be virtual #1054

merged 1 commit into from Nov 18, 2015

Conversation

304NotModified
Copy link
Member

IWcfLogReceiverClient LogReceiverWebServiceTarget.CreateLogReceiver() should be virtual

fixes #1050

bug as it was a non intended breaking change.

@304NotModified 304NotModified added enhancement Improvement on existing feature bug Bug report / Bug fix labels Nov 18, 2015
@304NotModified 304NotModified added this to the 4.2.1 milestone Nov 18, 2015
@codecov-io
Copy link

Current coverage is 72.92%

Merging #1054 into master will not affect coverage as of b30c661

@@            master   #1054   diff @@
======================================
  Files          263     263       
  Stmts        14875   14875       
  Branches      1618    1618       
  Methods          0       0       
======================================
  Hit          10847   10847       
  Partial        416     416       
  Missed        3612    3612

Review entire Coverage Diff as of b30c661

Uncovered Suggestions

  1. +0.08% via ...argets/FileTarget.cs#1918...1930
  2. +0.08% via ...argets/FileTarget.cs#1555...1567
  3. +0.08% via ...c/NLog/LogFactory.cs#180...191
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Nov 18, 2015
@304NotModified
Merge pull request #1054 from NLog/IWcfLogReceiverClient-CreateLogRec…
e4bceb8 
…eiver-virtual

LogReceiverWebServiceTarget.CreateLogReceiver()  should be virtual
@304NotModified 304NotModified merged commit e4bceb8 into master Nov 18, 2015
@304NotModified 304NotModified deleted the IWcfLogReceiverClient-CreateLogReceiver-virtual branch November 18, 2015 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bug report / Bug fix enhancement Improvement on existing feature
Projects
None yet
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io