Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added extra callsite unit tests #1099

Merged
merged 2 commits into from
Dec 20, 2015
Merged

Added extra callsite unit tests #1099

merged 2 commits into from
Dec 20, 2015

Conversation

304NotModified
Copy link
Member

test ${callsite} with a subclass. Needed for #1095

@304NotModified 304NotModified added the enhancement Improvement on existing feature label Dec 19, 2015
@codecov-io
Copy link

Current coverage is 72.92%

Merging #1099 into master will not affect coverage as of 7f18490

@@            master   #1099   diff @@
======================================
  Files          263     263       
  Stmts        14925   14925       
  Branches      1627    1627       
  Methods          0       0       
======================================
  Hit          10884   10884       
  Partial        418     418       
  Missed        3623    3623

Review entire Coverage Diff as of 7f18490

Uncovered Suggestions

  1. +0.09% via ...nternal/AspHelper.cs#206...218
  2. +0.09% via ...nternal/AspHelper.cs#188...200
  3. +0.09% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Dec 19, 2015
@304NotModified
Merge commit #1099 into 1070-FindCallingMethodOnStackTrace-v2
be1d500
@304NotModified 304NotModified added this to the 4.3 milestone Dec 20, 2015
304NotModified added a commit that referenced this pull request Dec 20, 2015
@304NotModified
Merge pull request #1099 from NLog/stacktrace-subclass-unit-tests
ce61fb3 
Added extra callsite unit tests
@304NotModified 304NotModified merged commit ce61fb3 into master Dec 20, 2015
@304NotModified 304NotModified deleted the stacktrace-subclass-unit-tests branch December 23, 2015 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@304NotModified @codecov-io