Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge from 4.2.3 (Improve performance of FileTarget + GDC) #1104

Merged
merged 7 commits into from
Dec 20, 2015
Merged

Merge from 4.2.3 (Improve performance of FileTarget + GDC) #1104

merged 7 commits into from
Dec 20, 2015

Conversation

304NotModified
Copy link
Member

fixes #1071

Also released in 4.2.3

Performance improvements (CPU & Memory) for the FileTarget.

Changes:

  • Improve file writing when file name has fixed name: no layout renderer in file name. 10 secs instead of 34 sec for 10 million. Sync writing with keepFileOpen="true", AutoFlush="false" and ConcurrentWrites="false".
  • Improved CleanupFileName by @epignosisx (Reduce Memory Allocations in FileTarget #1063)
  • Changes the performance of GDC toString
  • Added option CleanupFileName on filetarget for faster writing when using dynamic (=non-fixed) file name. Default true (=backwards-compatible)

epignosisx and others added 7 commits December 7, 2015 18:51
@epignosisx @304NotModified
rewrite CleanupInvalidFileNameChars to reduce memory allocations.
f56480a
@epignosisx @304NotModified
rename static member
4120ef4
@304NotModified
move to UTCnow (instead of now) for performance
33c0c1c 
really makes a difference after CPU/write tests
@304NotModified
Fix for SL
20e8038
@304NotModified
Added filename cache
ede8dab 
because CleanupInvalidFileNameChars is expensive
@304NotModified
Added CleanupFileName to FileTarget
4eb2319 
10 million messages, from 50 secs to 16 secs
@304NotModified
faster tostring
110d065 
from 16 -> 15 sec (10 million messages). 6~7%
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Dec 20, 2015
@304NotModified 304NotModified added this to the 4.3 milestone Dec 20, 2015
@codecov-io
Copy link

Current coverage is 72.96%

Merging #1104 into master will increase coverage by +0.04% as of 5b2819a

@@            master   #1104   diff @@
======================================
  Files          263     263       
  Stmts        14931   14967    +36
  Branches      1627    1633     +6
  Methods          0       0       
======================================
+ Hit          10888   10920    +32
- Partial        419     421     +2
- Missed        3624    3626     +2

Review entire Coverage Diff as of 5b2819a

Uncovered Suggestions

  1. +0.09% via ...nternal/AspHelper.cs#206...218
  2. +0.09% via ...nternal/AspHelper.cs#188...200
  3. +0.09% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

304NotModified added a commit that referenced this pull request Dec 20, 2015
@304NotModified
Merge pull request #1104 from NLog/4.2.3
33377f4 
Merge from 4.2.3 (Improve performance of FileTarget, performance GDC)
@304NotModified 304NotModified merged commit 33377f4 into master Dec 20, 2015
@304NotModified 304NotModified deleted the 4.2.3 branch December 23, 2015 22:23
@304NotModified 304NotModified changed the title Merge from 4.2.3 (Improve performance of FileTarget, performance GDC) Merge from 4.2.3 (Improve performance of FileTarget + GDC) Dec 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvement on existing feature
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@304NotModified @codecov-io @epignosisx